Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add bin folder to .gitignore #1196

Conversation

KClough
Copy link
Collaborator

@KClough KClough commented Jun 24, 2022

Summary:

Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).

Resolves #1195

Expected behavior:

Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).

When building the solution locally, the main/bin folder is generated. This should be ignored by source control.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@maximearmstrong maximearmstrong added this to In Review in The Tech Dashboard (archived) via automation Jun 27, 2022
@maximearmstrong maximearmstrong self-requested a review June 27, 2022 23:13
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @KClough

The Tech Dashboard (archived) automation moved this from In Review to Approved Jun 27, 2022
@maximearmstrong maximearmstrong merged commit ceb2a86 into MobilityData:master Jun 27, 2022
The Tech Dashboard (archived) automation moved this from Approved to Done Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Developer experience: add bin folder to .gitignore
2 participants