Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updates acceptance tests to use the Mobility Database Catalogs #1204

Merged
merged 8 commits into from
Jul 7, 2022

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Jul 6, 2022

Summary:

Closes #1143

This PR update the acceptance tests so that they use the Mobility Database Catalogs instead of the outdated Wikibase instance.

Expected behavior:

Acceptance tests should be run on the sources included in the Mobility Database Catalogs. Since the catalogs can be downloaded as a CSV file, acceptance tests should be much faster when fetching the URLs (no more waiting on the Wikibase API!). Also, the data is in greater quantity and more accurate.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@maximearmstrong maximearmstrong self-assigned this Jul 6, 2022
@maximearmstrong maximearmstrong added this to In Review in The Tech Dashboard (archived) via automation Jul 6, 2022
@maximearmstrong maximearmstrong changed the title Updates acceptance tests to use the Mobility Database Catalogs feat: Updates acceptance tests to use the Mobility Database Catalogs Jul 6, 2022
@maximearmstrong maximearmstrong marked this pull request as ready for review July 6, 2022 21:33
@bdferris-v2
Copy link
Collaborator

Meta comment: I don't think I'd ever looked too closely at the acceptance_test.yml script before. This thing is a beast! How many urls are in the old database? I count 1300+ in the new database. Is that an increase? I guess the project doesn't get pull requests /too/ often, but I hadn't realized just how many feeds were being downloaded with each update to a PR.

@maximearmstrong
Copy link
Contributor Author

Meta comment: I don't think I'd ever looked too closely at the acceptance_test.yml script before. This thing is a beast! How many urls are in the old database? I count 1300+ in the new database. Is that an increase? I guess the project doesn't get pull requests /too/ often, but I hadn't realized just how many feeds were being downloaded with each update to a PR.

We have 1332 GTFS Schedule sources in the Mobility Database catalogs. Previously, 1117 on the Wikibase instance (more actually, but we noticed that many were duplicates). So we will run acceptance tests on 215 additional sources.

A lot of downloads every time a PR is updated, indeed! It is possible to skip the acceptance tests by using the [acceptance test skip] string in a commit, so that the tests are only run when necessary.

Copy link
Collaborator

@bdferris-v2 bdferris-v2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - assuming the acceptance test runs to completion, this looks ready to go.

The Tech Dashboard (archived) automation moved this from In Review to Approved Jul 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1334 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 0eea0c4 here (report will disappear after 90 days).

@maximearmstrong maximearmstrong merged commit 67ce044 into master Jul 7, 2022
The Tech Dashboard (archived) automation moved this from Approved to Done Jul 7, 2022
@maximearmstrong maximearmstrong deleted the issue/1143/update-acceptance-tests-catalogs branch July 7, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update the Acceptance Tests by using the Mobility Database Catalogs
2 participants