Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update config.yml #1216

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Fix: Update config.yml #1216

merged 1 commit into from
Jul 25, 2022

Conversation

isabelle-dr
Copy link
Contributor

Tiny fixes to the welcome bot messages.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • [ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@github-actions
Copy link
Contributor

Thank you for this contribution! 🍰✨🦄

Information about source corruption

1 out of 1335 sources are corrupted.
The following sources are corrupted:

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 7c55c2e here (report will disappear after 90 days).

Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @isabelle-dr

@isabelle-dr
Copy link
Contributor Author

@maximearmstrong
Copy link
Contributor

Yes, there is an out-of-memory error occurring when validating Colectivos (Buenos Aires, Argentina) in the End to end big workflow:
Error: Process completed with exit code 137.

It seems the dataset is too big, but since it's the last one validated in the workflow, maybe we are using all the memory available in the virtual machine (see vm resources here).

This is not related to #1206, but it's part of the "are end-to-end workflows working correctly?" conversation. We experience a lot of problems with them lately, it would be good to investigate their behavior.

@isabelle-dr
Copy link
Contributor Author

Okay, merging this PR since the test failure seems unrelated. Thank you @maximearmstrong!

@isabelle-dr isabelle-dr merged commit 36d7e7c into master Jul 25, 2022
@isabelle-dr isabelle-dr deleted the isabelle-dr-update-welcome-bot branch July 25, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants