fix(docker): update path to CLI jar #1241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
:latest
Docker container build of themaster
branch is broken due to changes in #1229:I've made the following changes in this PR to both fix the issue and add a testing step that would catch breaks in the Docker layer:
build-push-action
for testing the Docker image before pushing--help
--help
to return 0 and be used to verify you can run a command, the README currently provides it as suchmain
/parseArguments
have a weird split of responsibilities currently. I tried a few ways to keepSystem.exit()
withinmain
as it is in all other cases, but they all ended up getting more gnarly.parseArguments
is already handling direct output and having side effects, so is already not a pure function.Dockerfile
to the new CLI jar build output location.dockerignore
to improve build caching when iterating locally