Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sign and Notarize MacOS App #1250

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Conversation

bdferris-v2
Copy link
Collaborator

Summary:

As tracked in #1200, this PR adds support for code-signing and notarizing the MacOS app. This will mean the user no longer has to ⌘-click the app to open it the first time. Note that they will still get the following warning when running the app for the first time:

Screen Shot 2022-08-23 at 7 34 14 PM

But they can just click "Ok" and the app will run. I don't think there is any way to avoid that dialog without distributing the app through the Mac App Store.

Closing #1200.

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

✅ Rule acceptance tests passed.
New Errors: 0 out of 1345 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1345 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
2 out of 1347 sources (~0 %) are corrupted.
Corrupted sources:
ar-buenos-aires-colectivos-buenos-aires-gtfs-1220
no-unknown-agder-kollektivtrafikk-as-gtfs-1078
Commit: 82e14e3
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

✅ Rule acceptance tests passed.
New Errors: 0 out of 1345 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1345 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
2 out of 1347 sources (~0 %) are corrupted.
Corrupted sources:
ar-buenos-aires-colectivos-buenos-aires-gtfs-1220
no-unknown-agder-kollektivtrafikk-as-gtfs-1078
Commit: ebe2933
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

✅ Rule acceptance tests passed.
New Errors: 0 out of 1347 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1347 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1347 sources (~0 %) are corrupted.
Commit: 93f5a6b
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2
Copy link
Collaborator Author

Ok, made a last few tweaks. This is now ready for final review and submission.

Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks so much @bdferris-v2! One small question before we merge.

.github/workflows/package_installers.yml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1352 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1352 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
1 out of 1353 sources (~0 %) are corrupted.
Corrupted sources:
ar-buenos-aires-colectivos-buenos-aires-gtfs-1220
Commit: faea014
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdferris-v2

@maximearmstrong maximearmstrong merged commit 2ba4054 into master Sep 13, 2022
@maximearmstrong maximearmstrong deleted the issue/1200/sign-mac-os branch September 13, 2022 23:01
@bdferris-v2 bdferris-v2 linked an issue Sep 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign the validator app with Apple and remove temporary fix
2 participants