-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sign and Notarize MacOS App #1250
Conversation
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
Ok, made a last few tweaks. This is now ready for final review and submission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thanks so much @bdferris-v2! One small question before we merge.
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @bdferris-v2
Summary:
As tracked in #1200, this PR adds support for code-signing and notarizing the MacOS app. This will mean the user no longer has to ⌘-click the app to open it the first time. Note that they will still get the following warning when running the app for the first time:
But they can just click "Ok" and the app will run. I don't think there is any way to avoid that dialog without distributing the app through the Mac App Store.
Closing #1200.
gradle test
to make sure you didn't break anything