feat: Check validator subclasses are annotated with @GtfsValidator #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvechnikov2
approved these changes
Oct 6, 2022
| + ": " | ||
| + validatorBaseClass.getSimpleName() | ||
| + " validator subclass should be annotated with @GtfsValidator") | ||
| .that(annotationInfo != null) |
There was a problem hiding this comment.
you can probably use
.that(annotationInfo).isNotNull();
There was a problem hiding this comment.
I originally wrote it this way, but the resulting error message from Truth isn't particular helpful / readable in the context of this check. With the isTrue() check, we get something like:
SometValidator: FileValidator validator subclass should be annotated with @GtfsValidator
expected to be true
With the alternate syntax, we get:
SometValidator: FileValidator validator subclass should be annotated with @GtfsValidator
expected not to be: null
I think the former is more understandable than the latter.
|
@asvechnikov2 I think we got the permissions fixed, but you'll need to LGTM again |
asvechnikov2
approved these changes
Oct 7, 2022
| + ": " | ||
| + validatorBaseClass.getSimpleName() | ||
| + " validator subclass should be annotated with @GtfsValidator") | ||
| .that(annotationInfo != null) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1262
Add a unit-test that checks that any subclass of SingleEntityValidator or FileValidator is also annotated with @GtfsValidator.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything