fix: Do not return non-zero exit code when exporting schema via CLI. #1272

bdferris-v2 · 2022-10-13T17:30:32Z

Summary:

Per discussion in #1256: refactor command-line argument parsing for clarity. Do not exit with non-zero exit code when exporting notices schema.

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with gradle test to make sure you didn't break anything
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues

…non-zero exit code when exporting notices schema.

asvechnikov2

Thanks!

bdferris-v2 added 2 commits September 20, 2022 18:00

Refactor command-line argument parsing for clarity. Do not exit with …

2569d03

…non-zero exit code when exporting notices schema.

Merge branch 'master' into issue/1256/export_schema

fb6171b

bdferris-v2 requested a review from asvechnikov2 October 13, 2022 17:30

bdferris-v2 linked an issue Oct 13, 2022 that may be closed by this pull request

Enhancement request: allow JAR to output notice_schema.json without validating anything #1256

Closed

asvechnikov2 approved these changes Oct 14, 2022

View reviewed changes

bdferris-v2 merged commit 23366db into MobilityData:master Oct 14, 2022

bdferris-v2 deleted the issue/1256/export_schema branch October 27, 2022 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Do not return non-zero exit code when exporting schema via CLI. #1272

fix: Do not return non-zero exit code when exporting schema via CLI. #1272

bdferris-v2 commented Oct 13, 2022

asvechnikov2 left a comment

fix: Do not return non-zero exit code when exporting schema via CLI. #1272

fix: Do not return non-zero exit code when exporting schema via CLI. #1272

Conversation

bdferris-v2 commented Oct 13, 2022

asvechnikov2 left a comment

Choose a reason for hiding this comment