Move GTFS field names from table loader to entity classes #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aababilov
force-pushed
the
field-names-entity-classes
branch
from
14d1169
to
dedd5e4
Compare
E.g., now use of GtfsStop.STOP_ID_FIELD_NAME instead of GtfsStopTableLoader.STOP_ID_FIELD_NAME. Motivation 1. Table loader classes should be only used for loading data tables. They should not be used by validator classes. 2. Our final goal is to stop generating table loader classes and instead make them usual classes that use a GTFS schema as a parameter. GTFS field names have to be generated, so we move them to entity classes that are generated anyway.
aababilov
force-pushed
the
field-names-entity-classes
branch
from
dedd5e4
to
2cc8380
Compare
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g., now use
GtfsStop.STOP_ID_FIELD_NAMEinstead ofGtfsStopTableLoader.STOP_ID_FIELD_NAME.Motivation