Separate table loading logic from table structure #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aababilov
force-pushed
the
table-descriptors
branch
4 times, most recently
from
9ed795a
to
fa7a467
Compare
aababilov
force-pushed
the
table-descriptors
branch
from
fa7a467
to
af7f92a
Compare
aababilov
force-pushed
the
table-descriptors
branch
from
af7f92a
to
bac0751
Compare
asvechnikov2
approved these changes
Dec 14, 2022
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFeedLoader.java
Outdated
Show resolved
Hide resolved
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating GtfsTableLoader classes, now we generate GtfsTableDescriptor which is used by a non-generated AnyTableLoader class.
GtfsTableDescriptor only contains information about table fields but does not implement parsing or validation. This way the new GtfsTableDescriptor is simpler than GtfsTableLoader.
AnyTableLoader class can support GTFS extensions in future.