Generate registries of tables and validators #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use the potentially unsafe ClassPath library that requires a lot of permissions and is problematic to run in a secure sandbox. We are still using ClassPath in NoticeSchemaGenerator. This can be changed later.
aababilov
force-pushed
the
no-class-path
branch
from
6893257
to
550633f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use the potentially unsafe ClassPath library that requires a lot of permissions and is problematic to run in a secure sandbox.
This is an API change.
Old code.
New code.
ValidatorLoader.createForPackagesis removed. Create a custom implementation ofGtfsValidatorRegistryand callValidatorLoader.createFromRegistry.We are still using ClassPath in NoticeSchemaGenerator and VersionResolver. They are not used for validation.