Do not invoke single file validators if table indices were not generated #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a table has duplicated keys, then its indices won't be generated and the noticeContainer will contain errors. Single file validators may have undefined behaviour when called for such incomplete indices.
|
I gotta say, I have thoughts on this PR. I hear @aababilov 's concern, but this seems a heavy-handed way of addressing it. As implemented, a single-entity validation error will caused all single-file validators to skip execution, potentially missing out on a lot of useful validation. I'd rather write validators to be resilient to underlying data that is malformed than disable them entirely. What's more, multi-file validation rules are still run for feeds that potentially have duplicate key and foreign key validation errors as well. Do we have to disable those as well? |
aababilov
added a commit
to aababilov/gtfs-validator
that referenced
this pull request
Dec 15, 2022
…t generated (MobilityData#1300)" This reverts commit a6cb3ed.
|
Makes sense to me, Brian. Reverted in #1303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a table has duplicated keys, then its indices won't be generated and the noticeContainer will contain errors. Single file validators may have undefined behaviour when called for such incomplete indices.