fix: byTranslationKey() for multi-key schemas without translations.txt support #1302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@PrimaryKey(translationRecordIdType)
field is used to indicated which keys, if any, for a given GTFS entity can be used for performingtranslations.txt
lookups viabyTranslationKey()
methods generated in the table container. Currently, code inTableContainerIndexGenerator
will generate an implementation forbyTranslationKey()
even if none of the @PrimaryKey fields have been marked as the translation RECORD_ID. This can lead to some weird behavior where the method will return a value even if none should be returned or generate code that does not actually compile.This PR fixes this behavior by no longer generating a
byTranslationKey()
implementation if the entity type does not support. Instead, empty is returned.Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything