-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move key annotation and entity interfaces into a new model
module
#1362
Conversation
…This will allow us to break up some potential circular dependencies with upcoming support for notice documentation generation.
✅ Rule acceptance tests passed. |
Now wondering if this should have been |
We can always start with this simple approach(just model) and refactor in the future adding the model back to the core as |
Fair enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
✅ Rule acceptance tests passed. |
…This will allow us to break up some potential circular dependencies with upcoming support for notice documentation generation. (MobilityData#1362)
…This will allow us to break up some potential circular dependencies with upcoming support for notice documentation generation. (MobilityData#1362)
This will allow us to break up some potential circular dependencies with upcoming support for notice documentation generation, as discussed in #1324 and #1361.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything