-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Web Validator Service Tests #1375
Conversation
@davidgamez Submitting my first pass at Springboot Controller tests as a draft PR. My first time doing this, so wanted to run it by you and make sure they look ok before I move on to the next method and helper classes. |
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
...est/java/org/mobilitydata/gtfsvalidator/web/service/controller/RunValidatorEndpointTest.java
Show resolved
Hide resolved
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Add unit tests for Web Service endpoints. Closes #1356
Expected behavior:
Should test expected responses and errors.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything