Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failing Docker Image workflow #1386

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Apr 13, 2023

Summary:

GitHub Docker Image step is failing in the master branch after #1382 was merged with the following message:

...
FAILURE: Build failed with an exception.

* What went wrong:
Task 'testReport' not found in root project 'gtfs-validator'.
...

Example Github action: https://github.com/MobilityData/gtfs-validator/actions/runs/4669878286/jobs/8268916282

In this PR the gradle task testReport is replaced by the testAggregateTestReport in the test step of docker workflow.

Expected behavior:

Github docker workflow successfully runs.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez
Copy link
Member Author

@davidgamez davidgamez changed the title Fix/GitHub action docker test fix: Failing Docker Image workflow Apr 14, 2023
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: bb2c448
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez marked this pull request as ready for review April 14, 2023 16:18
@davidgamez davidgamez merged commit befb7fe into master Apr 14, 2023
334 checks passed
@davidgamez davidgamez deleted the fix/github-action-docker-test branch April 14, 2023 17:11
@welcome
Copy link

welcome bot commented Apr 14, 2023

🥳 Congrats on getting your first pull request merged!

bradyhunsaker pushed a commit to bradyhunsaker/gtfs-validator that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants