Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate Cypress for E2E testing #1396

Merged
merged 15 commits into from
Apr 28, 2023
Merged

feat: integrate Cypress for E2E testing #1396

merged 15 commits into from
Apr 28, 2023

Conversation

mijogu
Copy link
Contributor

@mijogu mijogu commented Apr 21, 2023

No description provided.

@welcome
Copy link

welcome bot commented Apr 21, 2023

Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:

  • fix: Bug with ssl network connections + Java module permissions.
  • `feat: Initial support for multiple @PrimaryKey annotations.
  • docs: update RELEASE.md with new process
    To get this PR to the finish line, please do the following:
  • Read our Contribution Guidelines
  • Follow Google Java style coding standards
  • Include tests when adding/changing behavior
  • Include screenshots

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mijogu mijogu marked this pull request as draft April 21, 2023 20:30
@mijogu mijogu force-pushed the test/init-cypress-testing branch 14 times, most recently from 4862ca3 to b247863 Compare April 25, 2023 19:58
@mijogu mijogu changed the title [WIP] Cypress tests: init cypress testing feat: integrate Cypress for E2E testing Apr 27, 2023
@themightychris
Copy link
Collaborator

Closes #1390

@mijogu mijogu marked this pull request as ready for review April 27, 2023 18:53
@themightychris themightychris mentioned this pull request Apr 27, 2023
Closed
davidgamez
davidgamez reviewed Apr 27, 2023
View reviewed changes
web/client/cypress/support/e2e.js Outdated Show resolved Hide resolved
web/client/cypress/support/commands.js Outdated Show resolved Hide resolved
.github/workflows/cypress_e2e_tests.yml Outdated Show resolved Hide resolved
@davidgamez
Copy link
Member

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @mijogu, great work. Can you kindly sign the Contributor License Agreement? Thanks!

davidgamez
davidgamez approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! 💪

@davidgamez davidgamez merged commit 4fba503 into MobilityData:master Apr 28, 2023
334 checks passed
@welcome
Copy link

welcome bot commented Apr 28, 2023

🥳 Congrats on getting your first pull request merged!

@themightychris themightychris deleted the test/init-cypress-testing branch April 28, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themightychris themightychris themightychris left review comments

@davidgamez davidgamez davidgamez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mijogu @CLAassistant @themightychris @davidgamez