Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use sentry spring-boot #1415

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

KClough
Copy link
Collaborator

@KClough KClough commented Apr 29, 2023

Summary:

Upgrade to use the spring-boot + logback framework integration from Sentry to provide better error capture.

Expected behavior:

Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@KClough KClough marked this pull request as draft April 29, 2023 16:42
@KClough
Copy link
Collaborator Author

KClough commented Apr 29, 2023

Marking as draft until the production application.properties can be updated with the new settings for this integration.

KClough and others added 2 commits May 18, 2023 21:03
The addition of a sentry secret into this file makes necessary its
removal from version control and enrollment in secrets management.
@KClough KClough force-pushed the feat/upgrade-sentry-spring-boot branch from 4c19f1f to 6b227fd Compare May 19, 2023 01:06
@KClough KClough marked this pull request as ready for review May 19, 2023 19:05
@KClough KClough requested a review from davidgamez May 19, 2023 19:05
@davidgamez davidgamez merged commit 6a4b89c into master May 23, 2023
19 checks passed
@davidgamez davidgamez deleted the feat/upgrade-sentry-spring-boot branch May 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants