Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgraded platform_without_parent_station notice to info #1444

Merged

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented May 23, 2023

Summary:

Downgraded platform_without_parent_station notice to info.
Relocated the notice to the info section in RULES.md

Expected behavior:

If a stop has no parent station and no platform, it will issue an INFO notice instead of a WARNING.

Please make sure these boxes are checked before submitting your pull request - thanks!

@jcpitre jcpitre linked an issue May 23, 2023 that may be closed by this pull request
@jcpitre jcpitre marked this pull request as ready for review May 23, 2023 15:08
@jcpitre jcpitre requested a review from davidgamez May 23, 2023 15:08
@jcpitre jcpitre linked an issue May 23, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 35 out of 1428 datasets (~2%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1428 sources (~0 %) are corrupted.
Commit: 2228a22
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@jcpitre jcpitre requested a review from isabelle-dr May 23, 2023 18:10
@jcpitre
Copy link
Contributor Author

jcpitre commented May 23, 2023

This change made a bunch of warning notices become info notices.
The comparator would give errors since there were too many differences in the outputs.
I had to skip the tests by putting [acceptance test skip] in the commit message.
See https://github.com/MobilityData/gtfs-validator/blob/master/docs/ACCEPTANCE_TESTS.md#instructions-to-run-the-pipeline

We should consider having a way to ignore specific items in the comparison (e.g. anything related to platform_without_parent_station should be ignored).
Maybe it's already there?

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 34 out of 1428 datasets (~2%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1428 sources (~0 %) are corrupted.
Commit: a88eb5b
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@davidgamez
Copy link
Member

❌ Invalid acceptance test. New Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. New Warnings: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%. Dropped Warnings: 34 out of 1428 datasets (~2%) are invalid due to code change, which is above the provided threshold of 1%. 0 out of 1428 sources (~0 %) are corrupted. Commit: a88eb5b Download the full acceptance test report here (report will disappear after 90 days). ❌ Invalid acceptance test.

This failure is expected as the PR downgrades a notice from warning to info.

@davidgamez davidgamez merged commit 12c87ce into master May 24, 2023
332 of 333 checks passed
@davidgamez davidgamez deleted the 1328-downgrade-platformwithoutparentstation-to-info branch May 24, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downgrade PlatformWithoutParentStation to Info
2 participants