Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web/service): change permissions for application.properties, service acount json, & newrelic.yml #1453

Merged
merged 2 commits into from
May 29, 2023

Conversation

lottspot
Copy link
Collaborator

The gcloud-secrets CLI will create these files with 0600 permissions, and does not document an option to change the mode. This patch uses the chown/chmod CLI utilities rather than --chown and --chmod flags because their support is not universal across docker versions or distributions which do not include buildkit (the cloudbuild environment provides one such distribution).

…ervice acount json, & newrelic.yml

The gcloud-secrets CLI will create these files with 0600 permissions,
and does not document an option to change the mode. This patch uses the
chown/chmod CLI utilities rather than --chown and --chmod flags because
their support is not universal across docker versions or distributions
which do not include buildkit (the cloudbuild environment provides one
such distribution).
@lottspot
Copy link
Collaborator Author

This change was validated by completing the following build successfully: https://console.cloud.google.com/cloud-build/builds;region=global/9a0cc20f-7604-4c23-a9a4-d76197f17e46?&project=web-based-gtfs-validator

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@davidgamez davidgamez merged commit a22e4d4 into master May 29, 2023
19 checks passed
@davidgamez davidgamez deleted the fix-websvc-newrelic branch May 29, 2023 14:00
@welcome
Copy link

welcome bot commented May 29, 2023

🥳 Congrats on getting your first pull request merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants