Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added missing_recommended_column notice #1470

Merged
merged 10 commits into from
Jun 21, 2023

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented Jun 1, 2023

Also removed missing_timepoint_column notice that it replaces.

Summary:
Closes #1350
Closes #1455

Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).

In the report, we should not have a missing_recommended_column if the timepoint column if absent from the stop_times.txt fille.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre jcpitre linked an issue Jun 1, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

❌ Invalid acceptance test.
New Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 539 out of 1428 datasets (~38%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 538 out of 1428 datasets (~38%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1428 sources (~0 %) are corrupted.
Commit: bd0e53e
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@jcpitre jcpitre marked this pull request as ready for review June 2, 2023 01:28
@jcpitre jcpitre requested a review from isabelle-dr June 2, 2023 01:29
Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works from a functionality standpoint. I have used one dataset that does not have the timepoint column in stop_times.txt on the current version and the version in this PR and it works as expected.

Current version: missing_timepoint_column notice.
Screenshot 2023-06-05 at 2 26 32 PM

New version: missing_recommended_column notice.
Screenshot 2023-06-05 at 2 25 12 PM

We will still need a code review for this PR!

@jcpitre jcpitre requested review from cka-y and qcdyx June 5, 2023 20:39
@jcpitre jcpitre force-pushed the 1350-create-a-recommendedcolumn-annotation branch from 907d72f to fb82492 Compare June 20, 2023 02:57
@github-actions
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 507 out of 1430 datasets (~35%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 535 out of 1430 datasets (~37%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 835a76d
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@jcpitre
Copy link
Contributor Author

jcpitre commented Jun 20, 2023

All failed comparison in the rules acceptance test are either:

  • missing_timepoint_column being replaced by missing_recommended_column, which is OK
  • For improper zip files where we say files are missing but previously it would still issue a missing_timepoint_column. The new way is to not issue a missing_recommended_column, which makes sense.

So I would consider the acceptance tests are passed.

@jcpitre jcpitre requested a review from davidgamez June 21, 2023 20:20
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 507 out of 1430 datasets (~35%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 535 out of 1430 datasets (~37%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 2930520
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@davidgamez davidgamez merged commit 2d8a554 into master Jun 21, 2023
332 of 333 checks passed
@davidgamez davidgamez deleted the 1350-create-a-recommendedcolumn-annotation branch June 21, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace missing_timepoint_column with missing_recommended_column Create a @RecommendedColumn annotation
3 participants