-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added missing_recommended_column notice #1470
feat: Added missing_recommended_column notice #1470
Conversation
❌ Invalid acceptance test. |
…dds a lot of notices [acceptance test skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR works from a functionality standpoint. I have used one dataset that does not have the timepoint
column in stop_times.txt
on the current version and the version in this PR and it works as expected.
Current version: missing_timepoint_column notice.
New version: missing_recommended_column notice.
We will still need a code review for this PR!
…ing to the execution.
907d72f
to
fb82492
Compare
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
❌ Invalid acceptance test. |
All failed comparison in the rules acceptance test are either:
So I would consider the acceptance tests are passed. |
core/src/test/java/org/mobilitydata/gtfsvalidator/validator/TableHeaderValidatorTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition!
❌ Invalid acceptance test. |
Also removed missing_timepoint_column notice that it replaces.
Summary:
Closes #1350
Closes #1455
Summarize the changes in the pull request including how it relates to any issues (include the #number, or link them).
In the report, we should not have a missing_recommended_column if the timepoint column if absent from the stop_times.txt fille.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything