Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Web Validator hangs after supplying non-zip URL #1445 #1481

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jun 5, 2023

Summary:

Fix for bug #1445 : Web Validator hangs after supplying non-zip URL

Expected behavior:
Error is displayed when the supplied url is invalid.

Screenshot 2023-06-05 at 12 04 48 PM

Implementation Details:
The load event for XMLHttpRequest is triggered once the request is complete even in the case of server error status code 500 which we send from web/service/controller/ValidationController.
Ref: https://javascript.info/xmlhttprequest

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y linked an issue Jun 5, 2023 that may be closed by this pull request
@cka-y cka-y merged commit 225dcc6 into master Jun 6, 2023
22 checks passed
@cka-y cka-y deleted the issue/1445 branch June 6, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Validator hangs after supplying non-zip URL
3 participants