Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Remove SeverityLevel from ValidationNotice constructor #1489

Merged
merged 7 commits into from
Jun 6, 2023

Conversation

bdferris-v2
Copy link
Collaborator

Closes #1472.

Cleans up ValidationNotice(SeverityLevel) constructor calls, as SeverityLevel is now read from the @GtfsValidationNotice annotation.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez
Copy link
Member

davidgamez commented Jun 6, 2023

Hi @bdferris-v2 , can we update the documentation located on NEW_RULES.md part of this PR?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: 969a050
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2
Copy link
Collaborator Author

@davidgamez done

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1430 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1430 sources (~0 %) are corrupted.
Commit: bf561f9
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit 260af81 into master Jun 6, 2023
333 checks passed
@davidgamez davidgamez deleted the issue/1472/severity_level branch June 6, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants