Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide an explanation to users about what a GTFS Component is #1505 #1512

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jun 26, 2023

Summary:

The GTFS Component now has a description to help the user understand its value.
The summary section is as wide as the compliance report.

Expected behavior:
image

Closes #1505
Closes #1467

Also fixes missing summary section for notices and missing description for the notice's fields.
Before:
image

With the changes:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cka-y cka-y merged commit d9c1ecb into master Jun 26, 2023
332 checks passed
@cka-y cka-y deleted the issue/1505 branch June 26, 2023 19:10
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: c2d32a1
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

davidgamez pushed a commit that referenced this pull request Jul 5, 2023
…1505 (#1512)

* fix: display tooltip text

* feat: gtfs component description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants