-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1423 only warn if feed contact email or url are both unset #1514
feat: 1423 only warn if feed contact email or url are both unset #1514
Conversation
add hasFeedContactEmailAndUrlShouldNotGenerateNotice test method add method comments
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/FeedContactValidator.java
Outdated
Show resolved
Hide resolved
❌ Invalid acceptance test. |
❌ Invalid acceptance test. |
…l-are-both-unset # Resolved Conflicts: # RULES.md
❌ Invalid acceptance test. |
1 similar comment
❌ Invalid acceptance test. |
…l or empty in the case of MissingFeedContactEmailAndUrlNotice
❌ Invalid acceptance test. |
I got 1 failing Rule acceptance test, but it's expected by design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
❌ Invalid acceptance test. |
Summary:
Close #1423
Only give a warning when both feed_contact_email and feed_contact_url are unset.
The screenshot uses the akocity_with_email.zip dataset. The feed_info.txt only contains feed_contact_email but doesn't contain feed_contact_url, the screenshot shows that the report does not generate a missing_recommended_field warning.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything