Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1423 only warn if feed contact email or url are both unset #1514

Merged

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jun 27, 2023

Summary:

Close #1423
Only give a warning when both feed_contact_email and feed_contact_url are unset.
The screenshot uses the akocity_with_email.zip dataset. The feed_info.txt only contains feed_contact_email but doesn't contain feed_contact_url, the screenshot shows that the report does not generate a missing_recommended_field warning.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)
    233C48A3-B94C-40F6-8685-F83E989732ED_1_105_c

@qcdyx qcdyx changed the title 1423 only warn if feed contact email or url are both unset feat: 1423 only warn if feed contact email or url are both unset Jun 27, 2023
@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 202 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 43ff5cb
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 202 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 66f5efb
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 203 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 7af9ddd
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

1 similar comment
@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 203 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 7af9ddd
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

…l or empty in the case of MissingFeedContactEmailAndUrlNotice
@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 203 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: e83bc70
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@qcdyx
Copy link
Contributor Author

qcdyx commented Jun 29, 2023

I got 1 failing Rule acceptance test, but it's expected by design.
image
The 425 new warnings: I create a new FeedContactEmailAndUrlNotice to check if both feed_contact_email and feed_contact_url are unset, we are aiming for new warnings to be discovered.
The 203 dropped warnings: the @recommended annotations are removed from feedContactEmail() and feedContactUrl() on purpose so that the new FeedContactValidator class takes charge of the validation.
Therefore, this PR is ready to be merged.

@qcdyx qcdyx mentioned this pull request Jun 29, 2023
4 tasks
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Contributor

❌ Invalid acceptance test.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 425 out of 1435 datasets (~30%) are invalid due to code change, which is above the provided threshold of 1%.
Dropped Warnings: 202 out of 1435 datasets (~14%) are invalid due to code change, which is above the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: ae3032f
Download the full acceptance test report here (report will disappear after 90 days).
❌ Invalid acceptance test.

@davidgamez davidgamez merged commit 18051a6 into master Jun 29, 2023
332 of 333 checks passed
@davidgamez davidgamez deleted the 1423-Only-warn-if-feed_contact_email-or-url-are-both-unset branch June 29, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only warn if feed_contact_email or url are both unset.
2 participants