Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added rest of GTFS components #1516

Merged
merged 7 commits into from
Jun 29, 2023
Merged

feat: added rest of GTFS components #1516

merged 7 commits into from
Jun 29, 2023

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jun 27, 2023

Summary:

This spreadsheet contains the list of all GTFS Components, and the conditions under which we can them "present" in the validator.
All adopted components are added.

Closes #1506
Closes #1513

Expected behavior:

image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as draft June 27, 2023 17:02
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: f937762
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: df2d043
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 268cade
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y marked this pull request as ready for review June 28, 2023 18:28
@cka-y cka-y requested a review from davidgamez June 28, 2023 18:45
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 460c000
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

new Pair<>("Pathways", GtfsPathway.FILENAME),
new Pair<>("Transfers", GtfsTransfer.FILENAME),
new Pair<>("Fares V1", GtfsFareAttribute.FILENAME),
new Pair<>("Fare Products", GtfsFareProduct.FILENAME),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 2640733
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: ae8a37d
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit 95a853d into master Jun 29, 2023
333 checks passed
@davidgamez davidgamez deleted the issue/1506 branch June 29, 2023 21:36
davidgamez pushed a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants