Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove unit-test that RULES.md is up-to-date with Notice classes. #1517

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

bdferris-v2
Copy link
Collaborator

Per #1515, we have moved away from RULES.md as the canonical source of notice documentation. As part of this deprecation, this PR removes the unit-test that checks that RULES.md has an entry for every notice class.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez
Copy link
Member

davidgamez commented Jun 27, 2023

Should we, as part of this PR, rewrite RULES.MD pointing to the web-validator documentation(https://gtfs-validator.mobilitydata.org/rules.html) and removing all the rules information? It can be done as a quick follow-up too.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 0ce4cb8
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2
Copy link
Collaborator Author

@davidgamez I've updated RULES.md per your suggestion.

@bdferris-v2 bdferris-v2 linked an issue Jun 27, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: fec2d10
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidgamez davidgamez merged commit d0cfd80 into master Jun 27, 2023
333 checks passed
@davidgamez davidgamez deleted the issue/1515/rules_md branch June 27, 2023 23:32
@qcdyx qcdyx self-assigned this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate RULES.md
3 participants