-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: report.json doesn't include details of parsing failures #1526
Conversation
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary:
When the stderr displays this error message:
the report.json file doesn't include anything related to the parsing failure.
Expected behavior:
Closes #1193
Since parsing failure specific notices are present in the validation reports (html & json), we removed all confusing logs related to parsing failures as shown bellow.
In the case of poa.zip dataset, the notice related to the parsing failure is
invalid_color
.Also,
MISSING_FILE
log for optional files has been removed as requested in #1193Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything