Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report.json doesn't include details of parsing failures #1526

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jul 3, 2023

Summary:
When the stderr displays this error message:

SEVERE:  ----------------------------------------- 
|       !!!    PARSING FAILED    !!!      |
|   Some validators were never invoked.   |
|   Please see report.json for details.   |
 ----------------------------------------- 

the report.json file doesn't include anything related to the parsing failure.

Expected behavior:
Closes #1193

Since parsing failure specific notices are present in the validation reports (html & json), we removed all confusing logs related to parsing failures as shown bellow.

SEVERE: 
 ----------------------------------------- 
|   Some validators were never invoked.   |
 ----------------------------------------- 
Skipped validators: FareAttributeAgencyIdValidator,GtfsAttributionAgencyIdForeignKeyValidator,GtfsAttributionRouteIdForeignKeyValidator,GtfsFareAttributeAgencyIdForeignKeyValidator,GtfsFareLegRuleNetworkIdForeignKeyValidator,GtfsFareRuleRouteIdForeignKeyValidator,GtfsRouteAgencyIdForeignKeyValidator,GtfsTransferFromRouteIdForeignKeyValidator,GtfsTransferToRouteIdForeignKeyValidator,GtfsTripRouteIdForeignKeyValidator,MatchingFeedAndAgencyLangValidator,RouteAgencyIdValidator,ShapeToStopMatchingValidator,StopTimeTravelSpeedValidator,TranslationFieldAndReferenceValidator,UrlConsistencyValidator

In the case of poa.zip dataset, the notice related to the parsing failure is invalid_color.

Also, MISSING_FILE log for optional files has been removed as requested in #1193

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y changed the title feat: updated logs logic fix: report.json doesn't include details of parsing failures Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: 77fdb2e
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: db792a1
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez added the status: Needs discussion We need a discussion on requirements before calling this issue ready label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1435 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1435 sources (~0 %) are corrupted.
Commit: c11d189
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx self-requested a review July 10, 2023 17:27
Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cka-y cka-y merged commit d105c3c into master Jul 13, 2023
333 checks passed
@cka-y cka-y deleted the issue/1193 branch July 13, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: Needs discussion We need a discussion on requirements before calling this issue ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

report.json doesn't include details of parsing failures
3 participants