-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automation of the update of the NOTICE_MIGRATION.md on releases #1530
Conversation
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
@@ -0,0 +1,106 @@ | |||
import pandas as pd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add documentation to this file, please.
@@ -0,0 +1,18 @@ | |||
from io import StringIO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add documentation to this file, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It's great that this will no longer be manual work after the next release.
@emmambd unfortunately, it won't work for the next release since the previous release didn't support the generation of |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
Summary:
Automation of the update of the NOTICE_MIGRATION.md on releases
Expected behavior:
Example of a PR on release is available here.
NOTE: this workflow won't work for the next release since the generation of
rules.json
isn't supported for release v4.1.0. This is why in the example provided bellow the severity of the notice in the PR body isn't accurate of version 4.1.0. Going forward the update will work as expected.Closes #1524
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything