Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automation of the update of the NOTICE_MIGRATION.md on releases #1530

Merged
merged 12 commits into from
Aug 4, 2023

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jul 7, 2023

Summary:

Automation of the update of the NOTICE_MIGRATION.md on releases

Expected behavior:
Example of a PR on release is available here.
NOTE: this workflow won't work for the next release since the generation of rules.json isn't supported for release v4.1.0. This is why in the example provided bellow the severity of the notice in the PR body isn't accurate of version 4.1.0. Going forward the update will work as expected.

Closes #1524

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as draft July 7, 2023 16:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1436 sources (~0 %) are corrupted.
Commit: 7ca6b95
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1436 sources (~0 %) are corrupted.
Commit: 80d23b2
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y changed the title Issue/1524 feat: Automation of the update of the NOTICE_MIGRATION.md on releases Jul 10, 2023
@cka-y cka-y marked this pull request as ready for review July 10, 2023 14:08
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1436 sources (~0 %) are corrupted.
Commit: e6c385d
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1436 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1436 sources (~0 %) are corrupted.
Commit: 0b8b435
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@@ -0,0 +1,106 @@
import pandas as pd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation to this file, please.

@@ -0,0 +1,18 @@
from io import StringIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation to this file, please.

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's great that this will no longer be manual work after the next release.

@cka-y
Copy link
Contributor Author

cka-y commented Aug 3, 2023

@emmambd unfortunately, it won't work for the next release since the previous release didn't support the generation of rules.json. But it will work for the next ones!

@cka-y cka-y requested a review from davidgamez August 3, 2023 16:46
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: 439d20f
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: 142a203
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y merged commit ccfdd65 into master Aug 4, 2023
333 checks passed
@cka-y cka-y deleted the issue/1524 branch August 4, 2023 15:27
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1439 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1439 sources (~0 %) are corrupted.
Commit: f0a2480
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate the NOTICE_MIGRATION.md on releases
3 participants