Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix Link in README.md #1546

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Conversation

1Maxnet1
Copy link
Contributor

@1Maxnet1 1Maxnet1 commented Aug 1, 2023

Summary:

While the former link provided only a 404 page, now one gets to the MobilityData site

Expected behavior:

When I click the link in the Readme.md I get to the Homepage of MobilityData

I did not run any unit tests or the like, as it is just a link in the Readme.md

While the former link provided only a 404 page, now one gets to the MobilityData site
@welcome
Copy link

welcome bot commented Aug 1, 2023

Thanks for opening this pull request! You're awesome. We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of titles with semantic prefixes:

  • fix: Bug with ssl network connections + Java module permissions.
  • feat: Initial support for multiple @PrimaryKey annotations.
  • docs: update RELEASE.md with new process
    To get this PR to the finish line, please do the following:
  • Read our Contribution Guidelines
  • Follow Google Java style coding standards
  • Include tests when adding/changing behavior
  • Include screenshots

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidgamez davidgamez merged commit 6547e2c into MobilityData:master Aug 4, 2023
14 checks passed
@welcome
Copy link

welcome bot commented Aug 4, 2023

🥳 Congrats on getting your first pull request merged!

@1Maxnet1 1Maxnet1 deleted the patch-1 branch August 5, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants