-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1537 get list of validators that couldnt run because of a parsing problem #1565
feat: 1537 get list of validators that couldnt run because of a parsing problem #1565
Conversation
…un-because-of-a-parsing-problem
…un-because-of-a-parsing-problem
…ct stubbing argument mismatch" error
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
1 similar comment
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
main/src/main/java/org/mobilitydata/gtfsvalidator/runner/ValidationRunner.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Show resolved
Hide resolved
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
core/src/test/java/org/mobilitydata/gtfsvalidator/validator/DefaultValidatorProviderTest.java
Show resolved
Hide resolved
…tput validators that couldn't run due to parsing problems
@qcdyx Can you show an example of how the parsing error output message will look now / give me instructions on how to generate it? This will help with QA. |
✅ Rule acceptance tests passed. |
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
1 similar comment
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
…un-because-of-a-parsing-problem
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
✅ Rule acceptance tests passed. |
@emmambd I created a dataset where the agency.txt file did not have an agency name. Here is what is printed:
|
Reformatted the output
…un-because-of-a-parsing-problem
✅ Rule acceptance tests passed. |
…un-because-of-a-parsing-problem
✅ Rule acceptance tests passed. |
Summary:
Closes #1537
My solution goes thru both SingleEntityValidators and SingleFileValidators, gathers validators that have dependencies with parsing errors. From my perspectives, we should decouple this problem into two parts. First, get the list of validators that couldn't run due to parsing errors. Second, a new logic could be added into the gtfs-validator - if we don't have this and that text files, then validator A B C should not run. @emmambd I request all dev team for code review. Let me know your opinion on the idea of decoupling this issue.
Expected behavior:
You will see the following info printing out if there's validators that couldn't run due to parsing errors
| Some validators were skipped due to parsing problems. |
Validators with Parsing Errors: BikesAllowanceValidator,GtfsAttributionRouteIdForeignKeyValidator,GtfsFareLegRuleNetworkIdForeignKeyValidator,GtfsFareRuleRouteIdForeignKeyValidator,GtfsRouteAgencyIdForeignKeyValidator,GtfsTransferFromRouteIdForeignKeyValidator,GtfsTransferToRouteIdForeignKeyValidator,GtfsTripRouteIdForeignKeyValidator,RouteAgencyIdValidator,ShapeToStopMatchingValidator,StopTimeTravelSpeedValidator,TranslationFieldAndReferenceValidator,UrlConsistencyValidator
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything