Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Package installers CI step failing #1568

Merged
merged 8 commits into from
Sep 12, 2023
Merged

Conversation

davidgamez
Copy link
Member

@davidgamez davidgamez commented Sep 12, 2023

Summary:

As described in #1567, the Github actions associated with the MacOS certificate imports, notarization, and stapling were dependent on open-source projects that are not available anymore. This PR implements the MacOS certificate imports, notarization, and stapling using XCode terminal commands.

Fixes #1567

Expected behavior:

GTFS Validator App is signed and notarized.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez
Copy link
Member Author

Screenshot of the downloaded app showing properly notarized. Look for text ...Apple checked it for malicious software and none was detected....
Screenshot 2023-09-12 at 2 38 09 PM

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1470 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1470 sources (~0 %) are corrupted.
Commit: 1117d07
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit 6398021 into master Sep 12, 2023
334 checks passed
@davidgamez davidgamez deleted the fix/package-installers branch September 12, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package installers CI step failing
2 participants