Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: initialized tooltip in the report.html #1581

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Sep 18, 2023

initialize tooltip in report.html
return non-empty string when getting comment for field in NoticeView

Summary:

Closes #1561

Expected behavior:
Screenshot 2023-09-18 at 1 28 00 PM
Screenshot 2023-09-18 at 1 22 11 PM

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

return non-empty string when getting comment for field in NoticeView
@qcdyx qcdyx linked an issue Sep 18, 2023 that may be closed by this pull request
Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it fixes the bug! @qcdyx

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1478 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1478 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1478 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1478 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1478 sources (~0 %) are corrupted.
Commit: 72b8b73
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx merged commit 38717fa into master Sep 20, 2023
334 checks passed
@qcdyx qcdyx deleted the 1561-web-ui-tooltips-in-validator-report-broken branch September 20, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web UI: Tooltips in validator report broken
4 participants