-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Resolve release version from new /version endpoint. #1586
Conversation
@bdferris-v2 I'm a bit late to the party on this one. |
✅ Rule acceptance tests passed. |
@jcpitre that's a great point. Technically, the web validator doesn't check for the latest release version, so it wouldn't be counted here. But it's reasonable to want to distinguish between CLI and Desktop App traffic. It's also reasonable to distinguish between development vs prod traffic. To that end, I've add two parameters to the /version api call:
I've also verified with @davidgamez that it's possible to see these parameters in the logs. I think that should be sufficient to distinguish between the various type of traffic. Thoughts? |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Per discussion in #1520, we'd like to pull the current release version of the app from the new /version endpoint.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything