Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resolve release version from new /version endpoint. #1586

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

bdferris-v2
Copy link
Collaborator

Per discussion in #1520, we'd like to pull the current release version of the app from the new /version endpoint.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre
Copy link
Contributor

jcpitre commented Sep 28, 2023

@bdferris-v2 I'm a bit late to the party on this one.
If I understand correctly we want to call a version endpoint so we can count how many times the software is used?
With the ultimate goal of deprecating the desktop GUI version if we realize it's not really used.
I did not see how we distinguish between runs of the CLI version, the GUI version and the Web version.
Also will the runs of the app done during development be counted also?

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1472 sources (~0 %) are corrupted.
Commit: d7021c1
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@bdferris-v2
Copy link
Collaborator Author

@jcpitre that's a great point. Technically, the web validator doesn't check for the latest release version, so it wouldn't be counted here. But it's reasonable to want to distinguish between CLI and Desktop App traffic. It's also reasonable to distinguish between development vs prod traffic.

To that end, I've add two parameters to the /version api call:

  • application_type: an enum that will be CLI, DESKTOP, or WEB based on the application
  • current_version: the current application version. Will have a -SNAPSHOT suffix for dev builds.

I've also verified with @davidgamez that it's possible to see these parameters in the logs.

I think that should be sufficient to distinguish between the various type of traffic. Thoughts?

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1472 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1472 sources (~0 %) are corrupted.
Commit: 6beb991
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdferris-v2 bdferris-v2 merged commit f3704d7 into master Sep 28, 2023
333 checks passed
@bdferris-v2 bdferris-v2 deleted the issue/1520/version_resolver branch September 28, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants