feat: Support injection of arbitrary types via ValidationContext #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValidationContext is used to inject params to constructors of *Validator classes. ValidationContext initially supported only CountryCode and CurrentDateTime, e.g.: @Inject ExpiredCalendarValidator( CurrentDateTime currentDateTime, // Injected from ValidationContext GtfsCalendarTableContainer calendarTable, GtfsCalendarDateTableContainer calendarDateTable) {...} This change allows the user to inject any types required for custom validation logic.
bdferris-v2
reviewed
Nov 22, 2023
| private final ImmutableMap<Class<?>, Object> context; | ||
|
|
||
| private ValidationContext(ImmutableMap<Class<?>, Object> context) { | ||
| this.context = context; | ||
| } | ||
|
|
||
| /** | ||
| * Represents a name of a GTFS feed, such as "nl-openov". | ||
| * | ||
| * @return the @code{GtfsFeedName} representing the feed's name |
There was a problem hiding this comment.
Unrelated to your PR, but this method comment seems incorrect. Understood if you don't want to fix it here, but if you were willing.
There was a problem hiding this comment.
Let's fix it while I am here. This comment is pretty confusing.
bdferris-v2
approved these changes
Nov 22, 2023
|
Added @davidgamez as an FYI. |
|
Thanks a lot for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidationContext is used to inject params to constructors of *Validator classes. ValidationContext initially supported only CountryCode and CurrentDateTime, e.g.:
@Inject
ExpiredCalendarValidator(
CurrentDateTime currentDateTime, // Injected from ValidationContext
GtfsCalendarTableContainer calendarTable,
GtfsCalendarDateTableContainer calendarDateTable) {...}
This change allows the user to inject any types required for custom validation logic.