Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update references to Dataset Publishing Guidelines from #1601 #1609

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

emmambd
Copy link
Contributor

@emmambd emmambd commented Nov 25, 2023

Summary:

Dataset Publishing Guidelines and All Files Recommendations were moved from the best practices section of the spec to the reference file, and as referenced in #1601. This PR updates the links to the References sections of the corresponding rules so no links break.

Expected behavior:

mixed_case_recommended_field
expired_calendar

both link to https://gtfs.org/schedule/reference/.

@emmambd emmambd requested a review from jcpitre November 25, 2023 16:19
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

1 similar comment
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1477 sources (~0 %) are corrupted.
Commit: 799b444
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1477 sources (~0 %) are corrupted.
Commit: 3b8fafc
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmambd emmambd merged commit 26864ec into master Nov 28, 2023
335 checks passed
@emmambd emmambd deleted the 1601-url-ref-update branch November 28, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2023-11-17 — 1 new commit(s) made to reference.md in Google Transit's repo
2 participants