Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validator version displayed in validator report summary #1627

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented Dec 21, 2023

Summary:

Fixes #1620
the problem was that we were using the same Docker image for staging and prod.
Configured so the staging Docker image has a different name than the production one.

Expected behavior:
After executing the web_svc_pr.yml github action, tested that:

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre jcpitre linked an issue Dec 21, 2023 that may be closed by this pull request
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcpitre jcpitre merged commit 3d5ef6f into master Dec 22, 2023
19 checks passed
@jcpitre jcpitre deleted the 1620-fix-validator-version-displayed-in-validator-report-summary branch December 22, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix validator version displayed in validator report summary
2 participants