Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decreasing_or_equal_stop_time_distance includes prevShapeDistTraveled #1631

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Jan 4, 2024

Summary:
decreasing_or_equal_stop_time_distance includes prevShapeDistTraveled, not prevStopTimeDistTraveled

Closes #1556

Expected behavior:
The name of the field in the report in now replaced from prevStopTimeDistTraveled to prevShapeDistTraveled in the report.
Note: the logic was already implemented - it was prevShapeDistTraveled that was in the report but under the name prevStopTimeDistTraveled.

Using this feed, we get:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as ready for review January 4, 2024 16:15
Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1477 sources (~0 %) are corrupted.
Commit: cc67976
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jan 9, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1477 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1477 sources (~0 %) are corrupted.
Commit: 6843241
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@davidgamez davidgamez merged commit 3edf968 into master Jan 9, 2024
333 checks passed
@davidgamez davidgamez deleted the feat/1556 branch January 9, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decreasing_or_equal_stop_time_distance: should include prevShapeDistTraveled, not prevStopTimeDistTraveled
2 participants