Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added GtfsNetworkSchema #1660

Merged
merged 5 commits into from
Jan 25, 2024
Merged

feat: added GtfsNetworkSchema #1660

merged 5 commits into from
Jan 25, 2024

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Jan 25, 2024

Summary:

Part 3 of #1640
Closes #1640

Expected behavior:
added a new GtfsNetworkSchema in code which represents the networks.txt.
https://docs.google.com/spreadsheets/d/1iyb8SCRxEXiK8-PHq0_Ut1_QUbeUEbQF6yZiA54WztU/edit#gid=1906649886

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx requested a review from davidgamez January 25, 2024 14:49
Copy link
Contributor

This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: ./gradlew goJF.

@emmambd
Copy link
Contributor

emmambd commented Jan 25, 2024

Screenshot 2024-01-25 at 11 04 58 AM

Route-based fares appears! LGTM on a QA side.

Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1481 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1481 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1481 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1481 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1481 sources (~0 %) are corrupted.
Commit: 19b685b
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1481 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1481 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1481 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1481 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1481 sources (~0 %) are corrupted.
Commit: 9923f59
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@qcdyx qcdyx merged commit 6dcb8e7 into master Jan 25, 2024
333 checks passed
@qcdyx qcdyx deleted the 1640-add-GtfsNetworkSchema branch January 25, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add remaining GTFS Features to the Validator
4 participants