Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generated CLI package installer #1680

Merged
merged 4 commits into from
Mar 4, 2024
Merged

feat: generated CLI package installer #1680

merged 4 commits into from
Mar 4, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Feb 27, 2024

Summary:
Closes #1674

Expected behavior:
CLI jar is now part of the artifacts in the Package Installers github action. The name is gtfs-validator-cli-[commit short hash]
Working example

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as ready for review February 27, 2024 20:03
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I add two non-blocking comments.

.github/workflows/package_installers.yml Outdated Show resolved Hide resolved
.github/workflows/package_installers.yml Outdated Show resolved Hide resolved
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪

Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1495 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1495 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1495 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1495 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
16 out of 1511 sources (~1 %) are corrupted.
Corrupted sources:
ae-abu-dhabi-emirate-department-of-municipalities-and-transport-gtfs-1329
ar-buenos-aires-subterraneos-de-buenos-aires-subte-gtfs-6
at-unknown-bean-shuttle-gtfs-859
at-wien-wiener-lokalbahnen-wlb-gtfs-648
au-new-south-wales-byron-easybus-gtfs-666
au-queensland-bowen-gtfs-1167
au-queensland-duffys-buses-and-stewarts-sons-coaches-gtfs-672
au-queensland-haidleys-panoramic-coaches-gtfs-654
au-queensland-mackay-transit-coaches-gtfs-678
au-queensland-sunbus-rockhampton-gtfs-907
au-queensland-translink-brisbane-gtfs-1215
au-tasmania-merseylink-gtfs-1251
au-victoria-mornington-railway-gtfs-1281
be-vlaams-gewest-de-lijn-gtfs-684
fr-auvergne-rhone-alpes-cars-region-auvergne-rhone-alpes-transisere-gtfs-985
fr-grand-est-rezo-gtfs-1897
Commit: da12825
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y merged commit b36f2f7 into master Mar 4, 2024
281 checks passed
@cka-y cka-y deleted the feat/1674 branch March 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate CLI package installers with each merge to master
2 participants