-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generated CLI package installer #1680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I add two non-blocking comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💪
✅ Rule acceptance tests passed. |
Summary:
Closes #1674
Expected behavior:
CLI jar is now part of the artifacts in the
Package Installers
github action. The name isgtfs-validator-cli-[commit short hash]
Working example
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything