Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make stop_without_zone_id conditional on fare rule type #1681

Closed
wants to merge 4 commits into from
Closed

fix: make stop_without_zone_id conditional on fare rule type #1681

wants to merge 4 commits into from

Commits on Feb 29, 2024

  1. fix: make stop_without_zone_id conditional on type of fare rule with …

    …route containing stop defined (#1663)
    
    - Update `StopZoneIdValidator` to issue notice about a stop without `zone_id` defined only when the stop is contained in a trip contained in a route defined in a fare rule with zone fields defined.
    - Change from previous logic which warned about stops without `zone_id` defined if any fare rules had zone fields defined.
    - The warning is still only triggered for stops of location type `0`.
    - Zone fields in `fare_rules.txt` are `origin_id`, `destination_id`, and `contains_id`.
    michaelandrewkearney committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7d860d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    8ee6c74 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    132978c View commit details
    Browse the repository at this point in the history
  3. docs: update author email address

    Merge remote-tracking branch 'refs/remotes/origin/master'
    michaelandrewkearney committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8f2e7d8 View commit details
    Browse the repository at this point in the history