Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter out acceptance tests from validator usage report #1683

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Mar 4, 2024

Summary:

Expected behavior:

  • With skip_validator_update enabled, CLI bypasses update checks and usage tracking, reducing inflated analytics during tests.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@MobilityData MobilityData deleted a comment from github-actions bot Mar 4, 2024
@MobilityData MobilityData deleted a comment from github-actions bot Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1511 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1511 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1511 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1511 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1511 sources (~0 %) are corrupted.
Commit: 45df1e2
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

docs/USAGE.md Outdated Show resolved Hide resolved
cka-y and others added 2 commits March 4, 2024 13:50
…ationRunnerConfig.java

Co-authored-by: David Gamez <1192523+davidgamez@users.noreply.github.com>
@cka-y cka-y requested a review from davidgamez March 4, 2024 18:52
Copy link
Contributor

github-actions bot commented Mar 4, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1500 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1500 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1500 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1500 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
11 out of 1511 sources (~1 %) are corrupted.
Corrupted sources:
de-baden-wurttemberg-bodo-verkehrsverbund-gtfs-769
de-bayern-burgerbus-leupoldsgrun-landkreis-hof-gtfs-1152
it-regione-autonoma-della-sardegna-collegamenti-marittimi-grimaldi-gtfs-1192
lt-alytaus-apskritis-kautra-gtfs-1040
us-oregon-city-of-milton-freewater-public-transportation-gtfs-274
us-washington-intercity-transit-gtfs-266
us-washington-union-gap-gtfs-277
us-washington-washington-state-ferries-gtfs-283
us-washington-whatcom-transportation-authority-gtfs-284
us-wisconsin-beloit-transit-gtfs-392
us-wisconsin-metro-transit-gtfs-394
Commit: 71ede36
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y merged commit 50eb0f5 into master Mar 4, 2024
332 checks passed
@cka-y cka-y deleted the feat/1668 branch March 4, 2024 21:54
Copy link
Contributor

github-actions bot commented Mar 4, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1509 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1509 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1509 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1509 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
2 out of 1511 sources (~0 %) are corrupted.
Corrupted sources:
rs-beograd-republic-of-serbia-gtfs-1027
us-colorado-estes-transit-gtfs-459
Commit: 5a0ff8e
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out acceptance tests from validator usage report
2 participants