docs: update deprecated architecture information

[michaelandrewkearney]

Summary:

Updates documentation of the architecture to correct errors, reflect changes to generated class names, and include new annotations.

Expected behavior:

• The "Main" section accurately reflects the validator architecture.
• The "Generated Classes" section of main includes all generated classes.
• The "Adding new tables and fields" section instructions are more specific.
• "Annotation Definitions" table includes all annotations.
• All links direct to the appropriate file or folder.

In lieu of screenshots, see rich diff of architecture.md.

Please make sure these boxes are checked before submitting your pull request - thanks!

• Run the unit tests with gradle test to make sure you didn't break anything
• Add or update any needed documentation to the repo
• Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
• Linked all relevant issues
• Include screenshot(s) showing how this pull request works and fixes the issue(s)

[michaelandrewkearney]

Realized this may resolve #1645, although not in an automated way.

[davidgamez]

LGTM!