Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table not properly rendered in notices #1695

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix: table not properly rendered in notices #1695

merged 1 commit into from
Mar 7, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Mar 7, 2024

Summary:
Closes #1672
Tables in Markdown format do not properly render for notices fast_travel_between_consecutive_stops and duplicate_route_name. To address the issue I simply used HTML formatting like it was done for the route_long_name_contains_short_name notice.

Expected behavior:

  • For fast_travel_between_consecutive_stops:
    image
  • For duplicate_route_name:
    image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as ready for review March 7, 2024 16:09
Copy link
Contributor

@qcdyx qcdyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Mar 7, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: 621f3f2
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@cka-y cka-y merged commit ff04760 into master Mar 7, 2024
333 checks passed
@cka-y cka-y deleted the feat/1672 branch March 7, 2024 17:27
emmambd added a commit that referenced this pull request Mar 12, 2024
qcdyx added a commit that referenced this pull request Mar 13, 2024
* add table

* fix table to match #1695

* fix java doc error

* update caption styles

* web ui style update + add colons

---------

Co-authored-by: David Gamez Diaz <1192523+davidgamez@users.noreply.github.com>
Co-authored-by: Jingsi Lu <jingsi@mobilitydata.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table not properly rendered in notices
2 participants