Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: acceptance tests #848

Merged
merged 556 commits into from
Jan 10, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
556 commits
Select commit Hold shift + click to select a range
1ce7512
debug: remove cd
Jul 15, 2021
74c63d3
debug: pwd
Jul 15, 2021
324774d
debug: pip3 install requirements.txt
Jul 15, 2021
ef41f3c
debug: retrieve urls
Jul 15, 2021
297bc47
debug: typo
Jul 15, 2021
03d7343
debug: pip3
Jul 15, 2021
a3121c1
debug: echo
Jul 15, 2021
deb065d
debug: add . to path
Jul 15, 2021
4a9bdfa
debug: explore folder
Jul 15, 2021
a0f0a89
debug: explore folder
Jul 15, 2021
f57ef39
debug: try python instead of python3
Jul 15, 2021
0f3a6e2
debug: try python3 instead of python
Jul 15, 2021
f93680d
debug: move statement
Jul 15, 2021
3c6de3e
debug: remove .
Jul 15, 2021
95d7292
debug: checkout code
Jul 15, 2021
52fb322
debug: checkout code
Jul 15, 2021
b83dce5
debug: comment code
Jul 15, 2021
d8ed837
debug: install deps
Jul 15, 2021
f345715
debug: install deps -r
Jul 15, 2021
190e75e
debug: install deps using pip instead of pip3
Jul 15, 2021
a2641b7
debug: install deps pip3 -r
Jul 15, 2021
06660ad
debug: add step to persist metadata
Jul 15, 2021
82355f6
debug: remove "KEY" in env vars names
Jul 15, 2021
031a5ca
debug: remove "KEY" in env vars names
Jul 15, 2021
eaed6de
debug: remove trailing comma
Jul 15, 2021
18e3805
debug: explore folder for metadata
Jul 15, 2021
ccee48e
debug: fix path
Jul 15, 2021
a6f5d25
run workflow on reference jar and persist reports
Jul 15, 2021
ef4f3e8
Merge branch 'master' into new-test-module
Jul 28, 2021
9427105
refactor json that contains urls of latest versions
Jul 28, 2021
6ee8ee6
try execution with matrix
Jul 28, 2021
ae93848
fix syntax
Jul 28, 2021
9600397
fix path to metadata
Jul 28, 2021
6d77bab
fix typo in path to metadata
Jul 28, 2021
d225be1
try -r for jq
Jul 28, 2021
66eb03a
.root
Jul 28, 2021
70cec12
use json string
Jul 28, 2021
abbaa4e
fix typo in path
Jul 28, 2021
210224b
try to extract root content later in process
Jul 28, 2021
a2dc268
echo variable before assignation
Jul 28, 2021
1514afa
Merge branch 'new-test-module' of github.com:MobilityData/gtfs-valida…
Jul 28, 2021
8a85008
change step id
Jul 28, 2021
d4e99cc
access root later in process
Jul 28, 2021
e8d0426
fix syntax
Jul 28, 2021
58d757e
try tostring
Jul 28, 2021
780e62e
remove tostring
Jul 28, 2021
3c0ea9a
try with root
Jul 28, 2021
48212ed
fix path
Jul 28, 2021
7624022
fix path
Jul 28, 2021
7a8ac5b
try tostring with whole json file
Jul 28, 2021
54adb8f
try raw_input -R
Jul 28, 2021
43a0c60
apply suggestions from code review
Jul 29, 2021
3885651
apply google-style-format plugin
Jul 29, 2021
3169321
do not use temporary variable
Jul 30, 2021
649850b
execute jar in background
Sep 20, 2021
b00a4d7
fix workflow: add missing )
Sep 20, 2021
da9bfe8
Merge branch 'master' into new-test-module
Oct 4, 2021
8185d42
try matrix with 1000+ keys
Oct 4, 2021
0a2429b
upgrade output-comparator to java11
Oct 4, 2021
140577d
use small -r
Oct 4, 2021
b4f19a6
use java 11 in workflow
Oct 4, 2021
bb031c6
use fromJson in matrix declaration
Oct 5, 2021
588d4cc
remove root
Oct 5, 2021
9bbe5ac
remove fromJson from matrix init
Oct 5, 2021
7b36c38
remove fromJson from matrix usage
Oct 5, 2021
270dad9
try -R
Oct 5, 2021
1fbf1ad
use .root
Oct 5, 2021
a318799
use -r
Oct 5, 2021
f2d4be5
Merge branch 'master' into new-test-module
Oct 19, 2021
c1eca7b
remove changes on acceptance_test.yml and harvest_latest_versions.py
Oct 19, 2021
a954200
remove changes on cli/Arguments.java
Oct 19, 2021
3068ee5
new structure uses "sampleNotices" instead of "notices"
Oct 19, 2021
f0b99f1
new structure for the acceptance test report
Oct 20, 2021
02d0313
add CLI argument output_base
Oct 21, 2021
bd4c7dd
new acceptance test report structure
Oct 21, 2021
4dc92db
apply goJF
Oct 21, 2021
f1de579
apply goJF
Oct 21, 2021
6464fdc
remove unused method
Oct 21, 2021
739eb9b
fix tests
Oct 21, 2021
9f2abca
apply goJF
Oct 21, 2021
115399a
update documentation
Oct 21, 2021
0bc7b7c
Merge branch 'master' into new-test-module
Oct 21, 2021
6e481b5
Merge branch 'master' into new-test-module
Oct 26, 2021
dc3fb32
compare outputs in CI
Oct 26, 2021
6677f43
debug
Oct 26, 2021
95962ad
debug
Oct 26, 2021
e34f484
debug
Oct 26, 2021
69d9ef6
add _cli to version name
Oct 26, 2021
6a9f308
change artifact name
Oct 26, 2021
e22f43a
comment on PR
Oct 26, 2021
d846622
do not minify json
Oct 26, 2021
ce81cbd
fix typo
Oct 26, 2021
2016c21
debug
Oct 28, 2021
2a7ea79
debug
Oct 28, 2021
fec9bb0
debug
Oct 28, 2021
ed535ef
debug
Oct 28, 2021
bc6762a
debug: use env variable
Oct 28, 2021
5fd3a1d
debug: use env variable
Oct 28, 2021
7c08bd7
debug: use env variable
Oct 28, 2021
e95cb24
debug: use env variable
Oct 28, 2021
a19ba70
debug: use $
Oct 28, 2021
6a5b95e
debug: print commit sha
Oct 28, 2021
04fa7c3
touch
Oct 28, 2021
c6cedfc
debug: use $
Oct 28, 2021
4e19eeb
debug: use '
Oct 28, 2021
eabcdbc
touch
Oct 28, 2021
5ab8d4a
debug use \'
Oct 28, 2021
c26700e
debug
Oct 28, 2021
fe1eeb9
debug use fromJson
Oct 28, 2021
5cef12c
touch
Oct 28, 2021
27a4c9d
debug: use other syntax
Oct 28, 2021
8df54d3
debug: fix syntax
Oct 28, 2021
7d30d86
debug: use output
Oct 28, 2021
aaea2da
touch
Oct 28, 2021
c59a6dd
touch
Oct 28, 2021
56dbe17
fix syntax
Oct 28, 2021
822daae
debug: use \'
Oct 28, 2021
24e955c
use url
Oct 28, 2021
2cef099
use url
Oct 28, 2021
7d49f3b
use whole list of urls
Oct 28, 2021
1f64d68
use newErrors instead of newNotices
Oct 28, 2021
b6cb915
test: modify severity
Oct 28, 2021
121deb1
Merge branch 'master' into new-test-module
Oct 28, 2021
78e52ac
assess effect of #1022
Oct 28, 2021
d2a2b16
always persist reports and comment on PR
Oct 28, 2021
1789041
use latest.json [acceptance test skip]
Oct 28, 2021
8747c6f
assess changes introduced by #1022, #1028 and #1027
Oct 28, 2021
103fab9
set threshold to 1%
lionel-nj Oct 29, 2021
731e2a7
apply suggestions from code review
lionel-nj Nov 2, 2021
bf702a7
update documentation
Nov 2, 2021
c19dd30
update enable emoji use on windows
Nov 2, 2021
38d17d4
remove NoticeAggregate language
Nov 2, 2021
fa4edaa
update output-comparator/README.md [acceptance test skip]
lionel-nj Nov 2, 2021
9a398af
apply suggestions from code review
Nov 2, 2021
4315c00
update output-comparator/README.md [acceptance test skip]
lionel-nj Nov 2, 2021
2a2b59d
Merge branch 'new-test-module' of github.com:MobilityData/gtfs-valida…
Nov 2, 2021
389e100
use LinkedHashset
Nov 2, 2021
93473a4
simulate failure in validator execution
Nov 2, 2021
89d5720
simulate failure in validator execution
Nov 2, 2021
312091e
remove failure simulation
Nov 2, 2021
fe2de3a
fail on errors
Nov 2, 2021
7502ed3
apply suggestion from code review [acceptance test skip]
lionel-nj Nov 3, 2021
97a7b52
improve documentation
Nov 3, 2021
7252c0f
Merge branch 'new-test-module' of github.com:MobilityData/gtfs-valida…
Nov 3, 2021
00d6218
add url to datasets in acceptance test report
Nov 3, 2021
35f9cda
use static variable to define url pattern
Nov 3, 2021
4f863cf
update documentation to match latest development
Nov 3, 2021
cd92dd6
explain where source ids come from
Nov 3, 2021
c3d7b0f
explain where source ids come from
Nov 3, 2021
7654a0d
refactor: datasetId -> sourceId and unify related language [acceptanc…
Nov 3, 2021
49f8c0a
apply goJF [acceptance test skip]
Nov 3, 2021
2206143
update docs
Nov 3, 2021
fc84d94
explain why acceptance test are important [acceptance test skip]
Nov 3, 2021
7d880cb
update doc [acceptance test skip]
Nov 3, 2021
983088b
apply suggestions from code review [acceptance test skip]
lionel-nj Nov 5, 2021
4f0d698
Merge branch 'master' into new-test-module
Nov 9, 2021
1337454
Merge branch 'master' into new-test-module
Nov 10, 2021
c7ede50
remove changes on notice severity
Nov 10, 2021
5d3cc12
refactor: use model to define a validation report
Nov 12, 2021
24d918d
checkout repo + specify path to source urls
Nov 12, 2021
96b5ce9
touch
Nov 12, 2021
1b00213
remove uses key
Nov 12, 2021
3aaca97
explore folders
Nov 12, 2021
7327f4d
download datasets_metadata
Nov 12, 2021
8a36db4
explore folders
Nov 15, 2021
2c2297a
update regexp
Nov 15, 2021
a1d61ba
remove commented code
Nov 15, 2021
2229deb
Merge branch 'master' into new-test-module
Nov 15, 2021
29e9b18
update gtfs versions
Nov 15, 2021
c26a262
debug
Nov 15, 2021
ac4249d
revert changes on gtfs_older_versions.json
Nov 15, 2021
3cdd714
remove ls
Nov 15, 2021
949aa1f
exclude folders that contains . in their name
Nov 15, 2021
9c70609
explore folders
Nov 15, 2021
71787d2
use current dir
Nov 15, 2021
e9c812f
use other folder to store acceptance report
Nov 15, 2021
dcfcb1d
check existence of files
Nov 15, 2021
d9e08c6
use var
Nov 16, 2021
f73285e
implement comment generator
Nov 16, 2021
5300450
breaking change for test
Nov 16, 2021
09899ff
ci: comment generator
Nov 16, 2021
ebeb0bc
always persist report
Nov 16, 2021
fded3a7
fix syntax
Nov 16, 2021
7db4267
add extra job
Nov 16, 2021
7756668
fix syntax
Nov 16, 2021
d8ee272
fix path
Nov 16, 2021
c4a3229
fix path
Nov 16, 2021
93f5770
archive -> source
Nov 16, 2021
fffbd7c
specify bash
Nov 16, 2021
f8f6a6b
pass value as github env variable
Nov 16, 2021
9427d3f
remove brackets
Nov 16, 2021
8617756
use output variable
Nov 16, 2021
9f0d089
fix syntax
Nov 16, 2021
cea25af
collapse jobs
Nov 16, 2021
406d1f5
remove extra )
Nov 16, 2021
9612738
substitute characters \n \r and \%
Nov 16, 2021
9b89fa0
do not substitute %
Nov 16, 2021
7c9bd6d
use multiline for env variable
Nov 16, 2021
151e08d
use quotes inside comment
Nov 16, 2021
93ae6d8
use triple quotes
Nov 16, 2021
a55207d
use single curly brace
Nov 16, 2021
cd94947
work using 200 first sources
Nov 16, 2021
12b772f
using double curly braces
Nov 16, 2021
032087f
use 150 sources
Nov 16, 2021
3b30c4a
use github action to comment PR
Nov 16, 2021
dfcb74d
use all sources
Nov 16, 2021
b0998dc
revert changes
Nov 16, 2021
9b802c7
remove file
Nov 16, 2021
b54634b
revert changes
Nov 16, 2021
be16b5f
Merge branch 'master' into new-test-module
Nov 16, 2021
47dd09b
revert changes
lionel-nj Nov 16, 2021
97d745c
Merge branch 'master' into new-test-module
Nov 16, 2021
b347b1d
change comment message when no new notice was triggered [acceptance t…
Nov 16, 2021
be9c6af
revert changes on gtfs_latest_versions.json
Nov 16, 2021
b83c719
Merge branch 'new-test-module' of github.com:MobilityData/gtfs-valida…
Nov 16, 2021
22101ac
modify comment content [acceptance test skip]
Nov 17, 2021
d2c4c2c
Merge branch 'master' into new-test-module
Nov 19, 2021
0adbef0
apply suggestions from code review [acceptance test skip]
lionel-nj Nov 19, 2021
6abfc5e
Merge branch 'new-test-module' of github.com:MobilityData/gtfs-valida…
Nov 19, 2021
52e69ed
add an explicit comment if no new errors were found
Nov 19, 2021
c272477
remove JUnit section
Nov 19, 2021
b9fa6e4
SampleNotice -> NoticeReport
Nov 19, 2021
442914e
use LinkedTreeMap for consistency
Nov 19, 2021
757e07e
rename sampleNotices->contexts
Nov 23, 2021
ff7ed0b
clarify docs
Nov 23, 2021
8a1e2ee
io package
Nov 23, 2021
aa200fd
ValidationReport as a separate class
Nov 23, 2021
6f6741e
fix tests
Nov 23, 2021
36ffea2
implement serialize method
Nov 23, 2021
5b42134
update javadocs
Nov 23, 2021
22c133f
apply goJF
Nov 23, 2021
55dd94e
apply suggestions from code review
Dec 3, 2021
ee15adf
update documentation
Dec 3, 2021
ed3f537
apply suggestions from code review
Dec 3, 2021
0db2976
apply suggestions from code review:
Dec 8, 2021
b4183f3
additional unit tests
Dec 9, 2021
2fe22d2
additional unit tests
Dec 9, 2021
c7b1e43
apply goJF
Dec 9, 2021
c5bb88d
use auth@v0 to authenticate to gcs service
Dec 10, 2021
69bb8ee
apply code review suggestions
Dec 20, 2021
29d040e
Merge branch 'master' into new-test-module
Dec 20, 2021
7a43343
determine the number of corrupted sources
Dec 21, 2021
f540035
document that ValidationReport only stores errors
Dec 21, 2021
190720d
apply suggestion from code review:
Dec 23, 2021
28935a6
update workflow with path to source_corruption_report.json
Dec 23, 2021
3614ba3
fix path
Dec 23, 2021
092571b
only list corrupted sources when present add some glitters ✨
Dec 23, 2021
7d1e454
update doc [acceptance test skip]
Dec 23, 2021
2dadbae
apply suggestions from code review
Jan 10, 2022
5ef30ad
apply goJF [acceptance test skip]
Jan 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions integration/build.gradle
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
plugins {
id 'java'
}

group 'org.mobilitydata'
version "gtfs-validator-${System.getenv("versionTag")}"

sourceCompatibility = JavaVersion.VERSION_1_8
compileTestJava.options.encoding = "UTF-8"

repositories {
mavenCentral()
}
dependencies {
implementation project(':main')
testCompile group: 'junit', name: 'junit', version: '4.12'
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
/*
* Copyright 2021 MobilityData IO
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.mobilitydata.gtfsvalidator.integration;

public class Main {
public static void main(String[] argv) {
org.mobilitydata.gtfsvalidator.cli.Main.main(argv);
lionel-nj marked this conversation as resolved.
Show resolved Hide resolved
}
}
2 changes: 2 additions & 0 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ rootProject.name = 'gtfs-validator'
include 'core'
include 'processor'
include 'main'
include 'integration'

lionel-nj marked this conversation as resolved.
Show resolved Hide resolved