feat: Pass severityLevel to constructor of some notices #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…valid email, phone and URL Some clients (e.g, Google) may want to reduce severity to WARNING.
lionel-nj
reviewed
Apr 22, 2021
| long csvRowNumber, | ||
| String fieldName, | ||
| String fieldValue, | ||
| SeverityLevel severityLevel) { |
There was a problem hiding this comment.
We might want yo document via javadocs why this second constructor is needed.
lionel-nj
reviewed
Apr 22, 2021
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidPhoneNumberNotice.java
Show resolved
Hide resolved
lionel-nj
reviewed
Apr 22, 2021
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/InvalidUrlNotice.java
Show resolved
Hide resolved
lionel-nj
suggested changes
Apr 22, 2021
There was a problem hiding this comment.
Thanks @aababilov! These small documentation changes would be nice to add to add to this PR.
|
Thanks, PTAL! |
lionel-nj
approved these changes
Apr 22, 2021
|
Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass severityLevel to constructor of notices for invalid email, phone and URL.
Some clients (e.g, Google) may want to reduce severity to WARNING.