feat: Export infinity and NaN values in JSON #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some notices may have special double values (NaN, Infinity, -Infinity) in the context. If we do not allow their serialization, then an attempt to store validation results ends up with a runtime exception. Documentation for GSON library says the following. Section 2.4 of <a href="http://www.ietf.org/rfc/rfc4627.txt">JSON specification</a> disallows special double values (NaN, Infinity, -Infinity). However, <a href="http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-262.pdf">Javascript specification</a> (see section 4.3.20, 4.3.22, 4.3.23) allows these values as valid Javascript values. Moreover, most JavaScript engines will accept these special values in JSON without problem. So, at a practical level, it makes sense to accept these values as valid JSON even though JSON specification disallows them.
lionel-nj
approved these changes
May 5, 2021
There was a problem hiding this comment.
Thanks @aababilov that will certainly have a positive impact on #848 where we deserialize the validation reports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notices may have special double values (NaN, Infinity, -Infinity)
in the context. If we do not allow their serialization, then an attempt
to store validation results ends up with a runtime exception.
Documentation for GSON library says the following.
Section 2.4 of JSON specification disallows
special double values (NaN, Infinity, -Infinity). However,
Javascript
specification (see section 4.3.20, 4.3.22, 4.3.23) allows these values as valid Javascript
values. Moreover, most JavaScript engines will accept these special values in JSON without
problem. So, at a practical level, it makes sense to accept these values as valid JSON even
though JSON specification disallows them.