Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump debian version used in docker image #891

Merged
merged 5 commits into from
May 5, 2021

Conversation

lionel-nj
Copy link
Contributor

@lionel-nj lionel-nj commented May 5, 2021

closes #844

Summary:

This PR provides support to bump debian version used in docker image.

Expected behavior:

Pull the image generated for this bug fix:

  1. docker pull ghcr.io/mobilitydata/gtfs-validator:fix-debian-version-used-in-docker-image
  2. Run cat /etc/issue to see Debian version.

Capture d鈥檈虂cran, le 2021-05-05 a虁 14 37 03

Debian version is 10 馃帀

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@lionel-nj lionel-nj changed the title fix: debian version used in docker image fix: bump debian version used in docker image May 5, 2021
@lionel-nj lionel-nj linked an issue May 5, 2021 that may be closed by this pull request
@lionel-nj lionel-nj self-assigned this May 5, 2021
@lionel-nj lionel-nj requested a review from barbeau May 5, 2021 18:39
@lionel-nj lionel-nj marked this pull request as ready for review May 5, 2021 18:39
Copy link
Member

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this closes #844, right?

@lionel-nj
Copy link
Contributor Author

LGTM - this closes #844, right?

Yes - udpated the PR description to include that information.

@lionel-nj lionel-nj merged commit 6018ee0 into master May 5, 2021
@lionel-nj lionel-nj deleted the fix/debian-version-used-in-docker-image branch May 5, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New docker image is using debian version that's past its end-of-life
2 participants