feat: introduce -p CLI parameter to output beautified reports #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aababilov
requested changes
May 11, 2021
| @@ -36,6 +36,8 @@ | |||
| public class NoticeContainer { | |||
| private static final Gson DEFAULT_GSON = | |||
| new GsonBuilder().serializeNulls().serializeSpecialFloatingPointValues().create(); | |||
| private static final Gson PRETTY_GSON = | |||
There was a problem hiding this comment.
We risk to have those Gson objects out of sync. Let's try this:
private static final Gson PRETTY_GSON = new GsonBuilder(DEFAULT_GSON).setPrettyPrinting().create();
There was a problem hiding this comment.
Unfortunately the constructor GsonBuilder(Gson gson) is package-private and cannot be accessed from NoticeContainer class. What do you think of the following?
private static final Gson PRETTY_GSON = DEFAULT_GSON.newBuilder().setPrettyPrinting().create();https://www.javadoc.io/doc/com.google.code.gson/gson/2.8.5/com/google/gson/Gson.html#newBuilder--
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NoticeContainer.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/cli/Arguments.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/cli/ArgumentsTest.java
Outdated
Show resolved
Hide resolved
- remove new additional unit tests - sync Gson builders
aababilov
requested changes
May 12, 2021
core/src/main/java/org/mobilitydata/gtfsvalidator/notice/NoticeContainer.java
Outdated
Show resolved
Hide resolved
aababilov
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #838
Summary:
This PR provides support for an additional CLI parameter :
-p/--prettywhich takes no value. This is used to bautfy the generated reports.Expected behavior:
Sample usage
report.jsonsystem_errors.jsonPlease make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything