-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document ERROR notices #902
docs: document ERROR notices #902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I think only one thing is missing: the notice code for each notices. In the reports, the only way to find a notice is by its code, so I think we should add it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
closes #849
Summary:
This PR provides additional documentation for notices.
TODOs
NOTICES.md
inRULES.md
andNEW_RULES.md
Please make sure these boxes are checked before submitting your pull request - thanks!
[ ] Run the unit tests withgradle test
to make sure you didn't break anything[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)