-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs to clarify path to documentation for previous versions of the validator #905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this is still a bit confusing. For example, if I were new to the repo I'd think "There is a v2.0.0 in the list, but the below README also says v2.0.0 in the documentation, so they're probably the same".
I think there needs to be some explanation of what this README is, in context of the previous releases.
Maybe something like:
This README contains information for master branch of this project, which is under active development. If you'd like to view documentation for past releases of the project, see:
Thanks for the clarification @barbeau. |
…ator into task/update-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lionel-nj. More comments below.
I'd strongly suggest you have someone that's not familiar with the steps walk through the docs for each version (1.4.0, 2.0.0, and current master branch) after the next set of edits and try to complete the steps to make sure everything is accurate and understandable.
@isabelle-dr while working on documentation update, I included suggestions to fix #912, PTAL at e776d1b . |
I'd suggest nesting the 3 categories so it's clear they are all possible future rules:
|
@lionel-nj just one thing to change here so the title "Common cases of bad data" matches the label we chose "Community rule". |
Fixed in da7a817. Merging to master. |
Summary:
This PR clarifies the paths to documentation for previous versions of the validator
Expected behavior:
No code change.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything